Separate formula emit from evaluate. #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Feb 26, 2024
| @@ -56,8 +59,15 @@ class FormulaRuntime<Input : Any, Output : Any>( | |||
| * this [FormulaRuntime] instance. We will not accept any more [onInput] changes and will | |||
| * not emit any new [Output] events. | |||
| */ | |||
| @Volatile | |||
There was a problem hiding this comment.
To ensure that we see the latest value within emitOutputIfNeeded
Laimiux
commented
Feb 26, 2024
| private val inspector = FormulaPlugins.inspector(type = formula.type(), local = inspector) | ||
| private val implementation = formula.implementation() | ||
|
|
||
| @Volatile |
There was a problem hiding this comment.
To ensure that we see the latest value within emitOutputIfNeeded
Laimiux
commented
Feb 26, 2024
| @@ -44,6 +44,7 @@ internal class FormulaManagerImpl<Input, State, Output>( | |||
| * start new actions. And then, [performTerminationSideEffects] is called to clean | |||
| * up this [formula] and its child formulas. | |||
| */ | |||
| @Volatile | |||
There was a problem hiding this comment.
To ensure that we see the latest value within emitOutputIfNeeded
Laimiux
commented
Feb 26, 2024
| @@ -13,7 +13,9 @@ import java.util.concurrent.atomic.AtomicReference | |||
| * that there is happens-before relationship between each thread and memory changes are visible | |||
| * between them. | |||
| */ | |||
| class SynchronizedUpdateQueue { | |||
| class SynchronizedUpdateQueue( | |||
| val onEmpty: () -> Unit = {} | |||
There was a problem hiding this comment.
We add optional onEmpty so we can emit output only once all updates are processed.
JaCoCo Code Coverage 80.32% ✅
Generated by 🚫 Danger |
Laimiux
commented
Feb 26, 2024
| @@ -193,9 +203,6 @@ class FormulaRuntime<Input : Any, Output : Any>( | |||
| if (isExecutingEffects) return | |||
| executeTransitionEffects() | |||
|
|
|||
| if (!manager.isTerminated()) { | |||
There was a problem hiding this comment.
Will be emitted once the update queue is empty
Laimiux
force-pushed
the
laimonas/formula-non-blocking-emissions
branch
2 times, most recently
from
b5433ff to
fb7d19d
Compare
Laimiux
force-pushed
the
laimonas/formula-non-blocking-emissions
branch
from
fb7d19d to
d9f6708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, formula evaluations will have to wait until output emission is finalized. If formula output emission triggers an expensive render, it will block further processing until emission is done and likely will force subsequent updates to the main thread. To avoid that, we are separating emission from formula run.