Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for events arriving on background thread. #325

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add test for events arriving on background thread. #325

merged 1 commit into from
Jan 3, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Jan 3, 2024

What

Adding a test to document a behavior that there will be a crash if an event arrives on a different thread from the main.

@Laimiux Laimiux requested a review from Jawnnypoo January 3, 2024 20:25
@carrotkite
Copy link

JaCoCo Code Coverage 79.66% ✅

Class Covered Meta Status
com/instacart/formula/internal/ChildrenManager 80% 0% ✅
com/instacart/formula/FormulaRuntime 87% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 17f5b9d into master Jan 3, 2024
5 checks passed
@Laimiux Laimiux deleted the laimonas/main-thread branch January 3, 2024 20:44
Laimiux added a commit that referenced this pull request Jan 26, 2024
@Laimiux
Add test for events arriving on background thread. (#325)
2d1405a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jawnnypoo Jawnnypoo Jawnnypoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laimiux @carrotkite @Jawnnypoo