[Fragment] Replace bind with setOutput function. #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
force-pushed
the
laimonas/formula-fragment-set-output
branch
from
9a5d94d to
46f395d
Compare
Laimiux
commented
Dec 11, 2023
|
|
||
|
|
||
| abstract class ComposeViewFactory<RenderModel> : ViewFactory<RenderModel> { | ||
|
|
||
| override fun create(inflater: LayoutInflater, container: ViewGroup?): FeatureView<RenderModel> { | ||
| val view = ComposeView(inflater.context) | ||
| var firstRender = true |
There was a problem hiding this comment.
Moved in to formula fragment
JaCoCo Code Coverage 79.39% ✅
Generated by 🚫 Danger |
Laimiux
commented
Dec 11, 2023
| val lifecycleCallbacks: FragmentLifecycleCallback? = null, | ||
| ) { | ||
| class State<RenderModel>( |
There was a problem hiding this comment.
We don't need this State class anymore
Laimiux
commented
Dec 11, 2023
| /** | ||
| * Binds [FeatureView.State] to a [render] function. | ||
| */ | ||
| internal class FeatureViewBindFunction<RenderModel>( |
There was a problem hiding this comment.
Not needed anymore
alexanderbezverhni
approved these changes
Dec 12, 2023
formula-android/src/main/java/com/instacart/formula/android/FormulaFragment.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Simplifying
FeatureViewby replacingbindfunction with asetOutputone.