Handle duplicate child key errors more gracefully. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,4 +18,12 @@ object FormulaPlugins { | |||
| else -> ListInspector(listOf(global, local)) | |||
| } | |||
| } | |||
|
|
|||
| fun onDuplicateChildKey( | |||
There was a problem hiding this comment.
Do we want to generalize this to support other formula errors in the future? So something like:
onError(error: FormulaError)
where FormulaError is a sealed interface
sealed interface FormulaError {
data class DuplicateKeyError(
val parentFormulaType: KClass<*>,
val childFormulaType: KClass<*>,
val key: Any,
) : FormulaError
}
There was a problem hiding this comment.
Maybe in the future, but for now doesn't seem necessary
There was a problem hiding this comment.
Any downsides of making it more generic from the start? Would avoid having to make API changes in the future
There was a problem hiding this comment.
Given it's pretty easy to migrate to a different design, I prefer waiting for more than one use case before designing a generic thing.
jhowens89
approved these changes
Dec 7, 2023
Laimiux
force-pushed
the
laimonas/handle-duplicate-key-errors
branch
from
1a3b7af to
a4ca1e9
Compare
JaCoCo Code Coverage 79.54% ✅
Generated by 🚫 Danger |
dennisdeng2002
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Instead of crashing on duplicate child key, we now add an index and notify the global listener to fix the problem. This is better behavior in production than potentially breaking the whole screen.