[Formula Android] Add event listener to track performance. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
force-pushed
the
laimonas/formula-fragment-operation-listener
branch
from
66bf74d to
8b30740
Compare
JaCoCo Code Coverage 79.51% ✅
Generated by 🚫 Danger |
alexanderbezverhni
approved these changes
Nov 30, 2023
| @@ -47,6 +45,22 @@ object FormulaAndroid { | |||
| FormulaFragmentDelegate.fragmentEnvironment = fragmentEnvironment | |||
| } | |||
|
|
|||
| /** | |||
| * Initializes Formula Android integration. Should be called within [Application.onCreate]. | |||
There was a problem hiding this comment.
Does it need to be called before the DI injection call in [Application.onCreate]? If yes - might be worth mentioning it here.
There was a problem hiding this comment.
Not necessary because usually, the logic will not run until a fragment is shown.
gradle/merge-reports.gradle
Outdated
| reports.html.enabled = false | ||
| // reports.html.enabled = false |
There was a problem hiding this comment.
Yep, needed to debug a failure
Laimiux
force-pushed
the
laimonas/formula-fragment-operation-listener
branch
from
8b30740 to
5677405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding
EventListenerwithonFeatureInitialized,onViewInflated,onRenderedcallbacks to understand performance of each function.