Add a new global plugin API. #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 79.53% ✅
Generated by 🚫 Danger |
alexanderbezverhni
approved these changes
Nov 28, 2023
Comment on lines
11
to
13
| for (inspector in inspectors) { | ||
| inspector.onFormulaStarted(formulaType) | ||
| } |
There was a problem hiding this comment.
nit: maybe introduce private fun forEveryInspector(block: Inspector.() -> Unit) to make this class less verbose and a little more kt idiomatic?
forEveryInspector { onFormulaStarted(formulaType) }
Comment on lines
+1257
to
+1262
| val globalInspector = TestInspector() | ||
| FormulaPlugins.setPlugin(object : Plugin { | ||
| override fun inspector(type: KClass<*>): Inspector { | ||
| return globalInspector | ||
| } | ||
| }) |
There was a problem hiding this comment.
nit: should we have test cases for any possible (global, local) permutation, not only when both are not null?
There was a problem hiding this comment.
We have some tests for local only, added a new test for global only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable global introspection via a plugins API.