Skip to content

Commit

Permalink
Add more tests around missing cases for transition API. (#357)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Laimiux
Laimiux authored Mar 15, 2024
1 parent 95054a0 commit 4cae107
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 15 deletions.
4 changes: 2 additions & 2 deletions formula/src/main/java/com/instacart/formula/internal/TransitionUtils.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal object TransitionUtils {
/**
* Combines only effects transition result with another transition result.
*/
internal fun <State> TransitionContext<*, State>.combine(
internal fun <State> combine(
result: Transition.Result.OnlyEffects,
other: Transition.Result<State>
): Transition.Result<State> {
Expand All @@ -35,7 +35,7 @@ internal fun <State> TransitionContext<*, State>.combine(
/**
* Combines stateful result with the result of another transition.
*/
internal fun <State> TransitionContext<*, State>.combine(
internal fun <State> combine(
result: Transition.Result.Stateful<State>,
other: Transition.Result<State>
): Transition.Result<State> {
Expand Down
72 changes: 59 additions & 13 deletions formula/src/test/java/com/instacart/formula/TransitionApiTest.kt
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.instacart.formula

import com.google.common.truth.Truth
import com.google.common.truth.Truth.assertThat
import com.instacart.formula.internal.DelegateTransitionContext
import com.instacart.formula.internal.toResult
import com.instacart.formula.test.TestCallback
import com.instacart.formula.test.TestListener
import org.junit.Test

Expand All @@ -11,13 +13,32 @@ class TransitionApiTest {
@Test fun `none transition`() {
val transition = Transition<Unit, Int, Unit> { none() }
val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit)
Truth.assertThat(result).isEqualTo(Transition.Result.None)
assertThat(result).isEqualTo(Transition.Result.None)
}

@Test fun `none transition has no effects`() {
val result = Transition.Result.None
assertThat(result.effects).isEmpty()
}

@Test fun `state transition result with effect type but null effect`() {
val result = DelegateTransitionContext(Unit, 0)
.transition(1, Effect.Unconfined, null)

assertThat(result.state).isEqualTo(1)
assertThat(result.effects).isEmpty()
}

@Test fun `transition returns null if effect is null`() {
val result = DelegateTransitionContext(Unit, 0)
.transition(Effect.Unconfined, null)
assertThat(result).isEqualTo(Transition.Result.None)
}

@Test fun `stateful transition`() {
val transition = Transition<Unit, Int, Unit> { transition(state + 1) }
val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(1)
assertThat(result.state).isEqualTo(1)
}

@Test fun `stateful transition with effects`() {
Expand All @@ -29,7 +50,7 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(1)
assertThat(result.state).isEqualTo(1)

result.assertAndExecuteEffects()
testListener.assertTimesCalled(1)
Expand All @@ -54,7 +75,7 @@ class TransitionApiTest {
delegate(AddTransition(), 5)
}
val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(5)
assertThat(result.state).isEqualTo(5)
}

@Test fun `transition combine none transition with stateful transition`() {
Expand All @@ -63,7 +84,7 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(1)
assertThat(result.state).isEqualTo(1)
}

@Test fun `transition combine only effects transition with stateful transition`() {
Expand All @@ -74,7 +95,7 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(1)
assertThat(result.state).isEqualTo(1)

result.assertAndExecuteEffects()
testListener.assertTimesCalled(1)
Expand All @@ -86,7 +107,32 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(2)
assertThat(result.state).isEqualTo(2)
}

@Test fun `combine effect with none`() {
val effect = TestCallback()
val transition = Transition<Unit, Int, Unit> {
transition(effect = effect).andThen { none() }
}

transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertAndExecuteEffects()
effect.assertTimesCalled(1)
}

@Test
fun `combine stateful transition with only effects`() {
val effect = TestCallback()
val transition = Transition<Unit, Int, Unit> {
transition(state + 1).andThen {
transition(effect = effect)
}
}
val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
assertThat(result.state).isEqualTo(1)
result.assertAndExecuteEffects()

effect.assertTimesCalled(1)
}

@Test fun `transition combine keeps effect order`() {
Expand All @@ -97,10 +143,10 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(2)
assertThat(result.state).isEqualTo(2)

result.assertAndExecuteEffects()
Truth.assertThat(listener.values()).containsExactly(1, 2).inOrder()
assertThat(listener.values()).containsExactly(1, 2).inOrder()
}

@Test fun `state andThen another stateful result`() {
Expand All @@ -109,7 +155,7 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(3)
assertThat(result.state).isEqualTo(3)
}

@Test fun `state andThen empty result`() {
Expand All @@ -119,16 +165,16 @@ class TransitionApiTest {
}

val result = transition.toResult(DelegateTransitionContext(Unit, 0), Unit).assertStateful()
Truth.assertThat(result.state).isEqualTo(1)
assertThat(result.state).isEqualTo(1)
}

private fun <State> Transition.Result<State>.assertStateful(): Transition.Result.Stateful<State> {
Truth.assertThat(this).isInstanceOf(Transition.Result.Stateful::class.java)
assertThat(this).isInstanceOf(Transition.Result.Stateful::class.java)
return this as Transition.Result.Stateful<State>
}

private fun <State> Transition.Result<State>.assertAndExecuteEffects() {
Truth.assertThat(effects).isNotEmpty()
assertThat(effects).isNotEmpty()
for (effect in effects) {
effect.executable()
}
Expand Down

0 comments on commit 4cae107

Please sign in to comment.