PR feedback.

instacart · Nov 30, 2023 · 275064f · 275064f
1 parent 629884a
commit 275064f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/...android-compose/src/main/java/com/instacart/formula/android/compose/ComposeViewFactory.kt b/...android-compose/src/main/java/com/instacart/formula/android/compose/ComposeViewFactory.kt
@@ -33,7 +33,7 @@ abstract class ComposeViewFactory<RenderModel> : ViewFactory<RenderModel> {
                             firstRender = false
                             state.environment.eventListener?.onFirstModelRendered(
                                 fragmentId = state.fragmentId,
-                                durationInMillis = end - state.initialized,
+                                durationInMillis = end - state.initializedAtMillis,
                             )
                         }
                     }

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FeatureView.kt b/formula-android/src/main/java/com/instacart/formula/android/FeatureView.kt
@@ -22,7 +22,7 @@ class FeatureView<RenderModel>(
     val lifecycleCallbacks: FragmentLifecycleCallback? = null,
 ) {
     class State<RenderModel>(
-        val initialized: Long,
+        val initializedAtMillis: Long,
         val fragmentId: FragmentId,
         val environment: FragmentEnvironment,
         val observable: Observable<RenderModel>,

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FormulaFragment.kt b/formula-android/src/main/java/com/instacart/formula/android/FormulaFragment.kt
@@ -30,7 +30,7 @@ class FormulaFragment : Fragment(), BaseFormulaFragment<Any> {
         requireArguments().getParcelable<FragmentKey>(ARG_CONTRACT)!!
     }
 
-    private val initialized = SystemClock.uptimeMillis()
+    private val initializedAtMillis = SystemClock.uptimeMillis()
 
     private var featureView: FeatureView<Any>? = null
     private val stateRelay: BehaviorRelay<Any> = BehaviorRelay.create()
@@ -53,7 +53,7 @@ class FormulaFragment : Fragment(), BaseFormulaFragment<Any> {
         super.onViewCreated(view, savedInstanceState)
         featureView?.let { value ->
             val state = FeatureView.State(
-                initialized = initialized,
+                initializedAtMillis = initializedAtMillis,
                 fragmentId = getFormulaFragmentId(),
                 environment = FormulaFragmentDelegate.fragmentEnvironment(),
                 observable = stateRelay,

diff --git a/formula-android/src/main/java/com/instacart/formula/android/views/FeatureViewBindFunction.kt b/formula-android/src/main/java/com/instacart/formula/android/views/FeatureViewBindFunction.kt
@@ -28,7 +28,7 @@ internal class FeatureViewBindFunction<RenderModel>(
                     firstRender = false
                     environment.eventListener?.onFirstModelRendered(
                         fragmentId = state.fragmentId,
-                        durationInMillis = end - state.initialized,
+                        durationInMillis = end - state.initializedAtMillis,
                     )
                 }
             } catch (exception: Exception) {