Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx for Head Ident to be fetched from Attributes on AttributedString #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIx for Head Ident to be fetched from Attributes on AttributedString #71

wants to merge 1 commit into from

Conversation

darko55s
Copy link

Fixes #67

ngoleo
ngoleo reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor

@ngoleo ngoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @darko55s! Could you add a snapshot test for this scenario so we can prevent this from breaking in the future?

@darko55s
Copy link
Author

darko55s commented Mar 3, 2021

@ngocholo Yeah ill do that asap.

@timcmiller
Copy link

@darko55s @ngocholo I've been using this locally and noticed if I had a headIndent set the link(at point:) wouldn't account for the offset.

You need to change this line in Link.swift to

lineOrigin.x += penOffset

@frndev
Copy link

frndev commented Dec 14, 2021

Any news on this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoleo ngoleo ngoleo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attributed string attributes not preserved
4 participants
@darko55s @timcmiller @frndev @ngoleo