migrator: detach receivers during migration #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution attempted in 16e9cb9 didn't work as that receiver was detached by the Python interpreter executing the CLI command, not the one executing the task code in the worker. Signed-off-by: Jacopo Notarstefano <[email protected]>
Fixes the performance issue caused by invenio-collections by detaching its receiver during migration. Its work, in fact, is already handled by inspire-dojson since inspirehep/inspire-dojson#62. Signed-off-by: Jacopo Notarstefano <[email protected]>
jmartinm
approved these changes
Sep 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The solution attempted in 16e9cb9 didn't work as that receiver was
detached by the Python interpreter executing the CLI command, not
the one executing the task code in the worker.
Fixes the performance issue caused by invenio-collections by detaching
its receiver during migration. Its work, in fact, is already handled
by inspire-dojson since inspirehep/inspire-dojson#62.
Related Issue
Closes #1640
Checklist:
RFCand look for it).