Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF-1895- Update googleauth to support external account type authorisation in GCP #762

Closed
wants to merge 3 commits into from

Conversation

balasubramanian-s
Copy link
Contributor

Update googleauth dependency to support external account type

Description

This issue occurs because the train repository was using a old version of googleauth
Fix would be updating the googleauth gem in train repository but it has a dependency with google-api-client.
Since google-api-client monolith gem is deprecated, migrated the google-api-client in order to support external account type of authorisation.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Copy link
Contributor

Hello balasubramanian-s! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Signed-off-by: balasubramanian-s <[email protected]>
@balasubramanian-s
Copy link
Contributor Author

Fixes:
#757 - Upgrading google auth library was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant