-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for wrong OS detection in Windows Subsystem for Linux #521
Conversation
Signed-off-by: christian-wtd <[email protected]>
Hello christian-wtd! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
Signed-off-by: christian-wtd <[email protected]>
cmon... your rubocop does exact opposite offenses than mine... Signed-off-by: christian-wtd <[email protected]>
Alright, my initial approach was fixing WSL but breaking evrything else :-( |
Oh btw... |
In addition to the original bug this may fix also |
Code Climate has analyzed commit 7d0fef6 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sorry, but WSL is not a supported platform and isn't on our radar. |
@zenspider Fix takes two lines, why can't we add it? What is the possible negative impact? |
@bohdanyurov-gl We don't actively track closed PRs/issues so comments like this are easily lost in the ether. I know it's been most of a year since this PR was filed, if you'd like to continue the discussion feel free to file an issue :) I personally have no problem with WSL but someone from @inspec/foundation-team-reviewers may have more background on this than me. Thanks! |
This fixes the wrong OS detection in Windows Subsystem for Linux (WSL)
Description
We earlier detected windows because running cmd.exe works in WSL but we can detect that by running "which cmd.exe" which gives commadn not found in windows because which is a linux command.
Related Issue
#520
inspec/inspec#4310 (potentially)
Types of changes
Checklist: