Add ability to specify 'backend' in runner options #196
Conversation
Signed-off-by: Walter Dolce <[email protected]>
Signed-off-by: Walter Dolce <[email protected]>
|
You should be able to set the |
|
fixes #193 |
There was a problem hiding this comment.
Thank you for your contribution @walterdolce This is a great move in the right direction and a great contribution. I apologize for the delayed response.
| if config[:backend] | ||
| runner_options[:backend] = config[:backend] | ||
| else | ||
| runner_options[:backend] = 'ssh' |
There was a problem hiding this comment.
Why are we setting this as default?
There was a problem hiding this comment.
I think that's the current default isn't it?
There was a problem hiding this comment.
I think explicitly setting it here is surprising, however. If config[:backend] is unset, let's just leave runner_options[:backend] unset, and it will determine its own default.
There was a problem hiding this comment.
Please see previous comment
| @@ -214,6 +214,12 @@ def runner_options(transport, state = {}, platform = nil, suite = nil) # rubocop | |||
| # default to false until we default to true in inspec | |||
| runner_options[:backend_cache] = false | |||
| end | |||
|
|
|||
| if config[:backend] | |||
| runner_options[:backend] = config[:backend] | |||
There was a problem hiding this comment.
Are we sure backend is enough? This would only work if we use the user defaults. Is there a case where users configure different credentials for gcp, azure and aws?
There was a problem hiding this comment.
Very much so - which would actually be the production use case to have different creds
There was a problem hiding this comment.
I'm not sure what you want to do here. Do you want to remove it?
If so, why treating config[:backend] differently than config[:backend_config]? Shouldn't they both go?
| if config[:backend] | ||
| runner_options[:backend] = config[:backend] | ||
| else | ||
| runner_options[:backend] = 'ssh' |
There was a problem hiding this comment.
I think explicitly setting it here is surprising, however. If config[:backend] is unset, let's just leave runner_options[:backend] unset, and it will determine its own default.
Signed-off-by: Walter Dolce <[email protected]>
|
Apologies for the delay! Merge conflicts resolved. Plus a question. BTW newcontext-oss/kitchen-terraform#252 has been resolved differently and so this issue no longer applies. So happy to close this PR altogether if deemed unnecessary. |
|
Thanks @walterdolce will close for now. Thanks =) |
tas50
added
Status: Help Wanted
This builds on top of #195 to mitigate newcontext-oss/kitchen-terraform#252