Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs re: connection details and 'Experimental' warning #39

Merged
merged 6 commits into from
Jul 29, 2019

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Jul 23, 2019

Description

Adds instructions on how to configure InSpec to talk to Habitat in the README.

Adds warnings that this is an experimental project in one resource (for now during early review); once we all agree on copy edits, I'll copy it to the other three.

Related Issue

Fixes #38
Fixes #37

Indirectly fixes #34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

After this fix is merged, an InSpec microsite website push will be needed.

@clintoncwolfe clintoncwolfe added Type: Bug Feature not working as expected Aspect/Docs Write the fine manual labels Jul 23, 2019
@clintoncwolfe clintoncwolfe requested a review from mjingle July 23, 2019 18:21
Copy link

@ericcalabretta ericcalabretta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add 4.7.3 in the inspec.yml example we provide in the readme? Right now it has inspec_version: '>= 3.8.0'

Can you provide more details on what these settings are:

       "api_url": "http://dev-hab.my-corp.io",
        "cli_ssh_host": "dev-hab.my-corp.io"

It's covered in a little more detail in the train guide. I still don't 100% understand what those settings should be after reading both. The API section makes more sense to me.

Is it possible to run InSpec locally using these resources? I haven't been able to get it to work yet in my environment but I'll spend more time this afternoon trying.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@clintoncwolfe
Copy link
Contributor Author

clintoncwolfe commented Jul 24, 2019

Currently, it is not possible* to run the inspec scanner and the hab cli on the same machine - see inspec/train-habitat#12 , which would add this capability.

For now, if you want to run the two on the same physical machine, you'd want to start a supervisor in a VM that supports SSH and has a hab CLI installed in it.

  • That is, I suppose you might be able to SSH to localhost, if you are running an SSH server...

Copy link

@ericcalabretta ericcalabretta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i needed a few more fields for my config.json The user and key files settings were also required.

The cli_ssh_host field was also a little confusing without more description.

{
  "file_version": "1.1",
  "credentials": {
    "habitat": {
      "dev-hab": {
        "api_url": "http://IPorFQDN",
        "cli_ssh_host": "IPorFQDN",
        "cli_ssh_user": "USERNAME",
        "cli_ssh_key_files": "~/.ssh/KEYNAME"
      }
    }
  }
}

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

#### Connection Options for inspec-habitat

Here are the most commonly used options for inspec-habitat.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here are the most commonly used options for inspec-habitat.
The most commonly used connection options for inspec-habitat are for either HTTP API or SSH.

Copy link
Contributor Author

@clintoncwolfe clintoncwolfe Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter part of this suggestion is misleading. A user will typically support options for for both SSH and API access. I've added a sentence clarifying that fact.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mjingle mjingle self-requested a review July 26, 2019 21:00
@clintoncwolfe clintoncwolfe force-pushed the cw/improve-docs-formvp branch from 7dd9c36 to f4bc353 Compare July 29, 2019 17:08
@clintoncwolfe clintoncwolfe force-pushed the cw/improve-docs-formvp branch from f4bc353 to e611bd7 Compare July 29, 2019 18:27
@clintoncwolfe clintoncwolfe merged commit f63f217 into master Jul 29, 2019
@chef-ci chef-ci deleted the cw/improve-docs-formvp branch July 29, 2019 18:36
@clintoncwolfe clintoncwolfe restored the cw/improve-docs-formvp branch July 29, 2019 18:37
@clintoncwolfe clintoncwolfe deleted the cw/improve-docs-formvp branch July 29, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect/Docs Write the fine manual Type: Bug Feature not working as expected
Projects
None yet
3 participants