Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated resources #602

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

remove deprecated resources #602

wants to merge 11 commits into from

Conversation

sathish-progress
Copy link
Contributor

Signed-off-by: Sathish [email protected]

Description

remove deprecated resources
release as part V2

Issues Resolved

#600

Check List

@sathish-progress sathish-progress requested a review from a team as a code owner January 7, 2022 05:26
@sathish-progress sathish-progress added do not merge Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Jan 7, 2022
@sathish-progress sathish-progress requested a review from a team as a code owner January 11, 2022 04:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@IanMadd
Copy link
Contributor

IanMadd commented Jan 21, 2022

Are these going to be deprecated or EOL'd? Either way we need to update our documentation on https://docs.chef.io/inspec/resources/

@soumyo13
Copy link
Contributor

Nice!

@soumyo13
Copy link
Contributor

Approved. Is there more changes pending? Asking because there is a label "Do Not Merge"

@IanMadd
Copy link
Contributor

IanMadd commented Mar 9, 2022

I think we've got to be careful with this. All of the azurerm resources are listed here: https://docs.chef.io/inspec/resources/#azure

There's no notice under any of them that they're deprecated or when they will be EOL and so there may be people using them. It could create problems if these get yanked all of a sudden.

@sathish-progress
Copy link
Contributor Author

I think we've got to be careful with this. All of the azurerm resources are listed here: https://docs.chef.io/inspec/resources/#azure

There's no notice under any of them that they're deprecated or when they will be EOL and so there may be people using them. It could create problems if these get yanked all of a sudden.

@IanMadd , can we update that docs saying that it would be deprecated starting v2?

@IanMadd
Copy link
Contributor

IanMadd commented Mar 10, 2022

can we update that docs saying that it would be deprecated starting v2?

@sathish-progress We can. Is there a deprecation date or EOL date?

@sathish-progress
Copy link
Contributor Author

can we update that docs saying that it would be deprecated starting v2?

@sathish-progress We can. Is there a deprecation date or EOL date?

I don't have a date for now.. but when we are at 2.0 we can release them

@IanMadd IanMadd mentioned this pull request Mar 11, 2022
Merged
4 tasks
@dkumaras
Warning message review
cb476c3 
Signed-off-by: Deepa Kumaraswamy <[email protected]>
@netlify
Copy link

netlify bot commented Mar 31, 2022 •
edited
Loading

❌ Deploy Preview for inspec-azure failed.

Name Link
🔨 Latest commit cb476c3
🔍 Latest deploy log https://app.netlify.com/sites/inspec-azure/deploys/624577ec1572a50008cd38f0

IanMadd
IanMadd reviewed Mar 31, 2022
View reviewed changes
README.md
@@ -400,14 +400,15 @@ The behavior of the http client can be defined with the following parameters:

They can be defined as environment variables or resource parameters (has priority).

<hr>
{{< warning >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkumaras The {{< warning >}} shortcodes only work in Hugo, not in GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd left review comments

@soumyo13 soumyo13 soumyo13 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@sathish-progress sathish-progress

Labels
do not merge Documentation ReadyForDocs Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sathish-progress @IanMadd @soumyo13 @dkumaras