-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for aws waf v2 #974
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inspec-aws canceled.
|
Signed-off-by: Rob de Heer [email protected]
Given our recent updates to main and the train-aws v0.4.2 release you should be able to pull in upstream/main and your PR should hopefully pass to the next stage as the aws_sdk_wafv2 gem is now in train-aws. |
If you want to get this passing for now - add the needed gem to the Gemfile and this should get moving again. |
Documentation for the resources - which is likely a 'mostly copy' from the v1 docs - seems to be missing. |
@@ -330,6 +331,10 @@ def waf_client | |||
aws_client(Aws::WAF::Client) | |||
end | |||
|
|||
def waf_client_v2 | |||
aws_client(Aws::WAFWAFV2::Client) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is an extra 'WAF' here -
Aws::WAFV2::Client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lint
passes