Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nirbhay/aws_s3_storage_lens #784

Closed
wants to merge 17 commits into from
Closed

nirbhay/aws_s3_storage_lens #784

wants to merge 17 commits into from

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Nov 24, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar [email protected]

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

added resourcce and test
e442fa8 
Signed-off-by: Nirbhay Kumar <[email protected]>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners November 24, 2021 19:13
soumyo13 and others added 4 commits November 25, 2021 13:12
@soumyo13
Update libraries/aws_s3_storage_lenses.rb
1e5d5c3
@soumyo13
updated
9ba11ad 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
added unit tests
9433671 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
updated unit tests
3c91155 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13 soumyo13 changed the title Nirbhay/S3 Storage lens nirbhay/aws_s3_storage_lens Nov 25, 2021
@soumyo13 soumyo13 linked an issue Nov 25, 2021 that may be closed by this pull request
AWS::S3::StorageLens #792
Open
soumyo13
soumyo13 reviewed Dec 5, 2021
View reviewed changes
docs/resources/aws_s3_storage_lens.md Outdated Show resolved Hide resolved
docs/resources/aws_s3_storage_lens.md Outdated Show resolved Hide resolved
docs/resources/aws_s3_storage_lenses.md Outdated Show resolved Hide resolved
docs/resources/aws_s3_storage_lenses.md Outdated Show resolved Hide resolved
libraries/aws_s3_storage_lens.rb Outdated Show resolved Hide resolved
libraries/aws_s3_storage_lenses.rb Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 self-requested a review June 5, 2022 13:23
@netlify
Copy link

netlify bot commented Jun 6, 2022 •
edited
Loading

✅ Deploy Preview for inspec-aws canceled.

Name Link
🔨 Latest commit 55a8f6c
🔍 Latest deploy log https://app.netlify.com/sites/inspec-aws/deploys/629dc0d28cb41a0008c64037

@soumyo13 soumyo13 marked this pull request as draft June 14, 2022 16:47
@soumyo13
Copy link
Contributor

soumyo13 commented Dec 7, 2022

This PR can't be merged as this PR is not tested.

@soumyo13 soumyo13 closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

@soumyo13 soumyo13 Awaiting requested review from soumyo13

Assignees

@Nirbhay1997 Nirbhay1997

Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::S3::StorageLens
3 participants
@Nirbhay1997 @soumyo13 @sa-progress