Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PoC demo app auth works with oidc-client-ts #2206

Closed
wants to merge 1 commit into from

Conversation

angelo-v
Copy link

@angelo-v angelo-v commented Jul 4, 2022

This PR fixes bug #2202

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

New feature description

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

This PR bumps the version to .

Release Steps

  1. Look at the CHANGELOG.md to determine whether the release should be a major, minor, or patch release. Coordinate with the team to ensure the next version is agreed upon.
  2. Run npm run lerna-version -- <major|minor|patch> with the decided on version.
  3. Update the CHANGELOG.md to release the latest the version, and set the release date.
  4. Commit the changes on a release/vX.Y.Z branch
  5. Push to GitHub, create a PR, and merge once CI passes.
  6. Create a release on GitHub for the new version, using a combination of the release notes from the CHANGELOG.md and the automatically generated changes.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d6d8162:

Sandbox Source
solid-client-auth-browser-demo Configuration

@jeswr
Copy link
Contributor

jeswr commented May 18, 2023

Hi @angelo-v - what is the status of this PR? Do you plan to follow up or should I close it?

@jeswr
Copy link
Contributor

jeswr commented Jun 15, 2023

@angelo-v I'm closing this as it seems stale. Feel free to re-open if you would like for work on it to be continue.

@jeswr jeswr closed this Jun 15, 2023
@angelo-v
Copy link
Author

@jeswr I still find it important that solid-client-authn-js works with oidc-client-ts

Are there any updates on what was said in #2202 (comment) and #2202 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants