fix(get_hydrometrie_observations_tr): crashes when returns empty result

Closes #47
inrae · Dec 1, 2024 · 006610d · 006610d
1 parent b91a7ed
commit 006610d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -48,4 +48,4 @@ Encoding: UTF-8
 Language: en-US
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
diff --git a/R/get_hydrometrie.R b/R/get_hydrometrie.R
@@ -64,7 +64,7 @@ get_hydrometrie_observations_tr  <- function(...,
     endpoint = "observations_tr",
     ...
   )
-  if(!is.null(l)) {
+  if (length(l) > 0) {
     l <- lapply(l, function(x) {
       if (entities == "station") {
         if (is.null(x$code_station)) {
@@ -78,9 +78,8 @@ get_hydrometrie_observations_tr  <- function(...,
       return(x)
     })
     l[sapply(l, is.null)] <- NULL
-    l <- convert_list_to_tibble(l)
   }
-  return(l)
+  return(convert_list_to_tibble(l))
 }
 
 

diff --git a/tests/testthat/test-run_all_examples.R b/tests/testthat/test-run_all_examples.R
@@ -25,5 +25,3 @@ lapply(db, function(Rd_fun) {
     })
   }
 })
-
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,5 +25,3 @@ lapply(db, function(Rd_fun) {
		})
		}
		})