Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cat-voices): update key derivation path #1301

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(cat-voices): update key derivation path #1301

wants to merge 7 commits into from

Conversation

dtscalac
Copy link
Contributor

Description

Updates key derivation path based on new specification: #1300

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Nov 29, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Nov 29, 2024
@dtscalac dtscalac self-assigned this Nov 29, 2024
@dtscalac dtscalac requested review from LynxLynxx and removed request for minikin November 29, 2024 10:04
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

damian-molinski
damian-molinski previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

stevenj
stevenj requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are not required, just a suggestion.
Otherwise LGTM

catalyst_voices/packages/internal/catalyst_voices_services/lib/src/crypto/key_derivation.dart Outdated Show resolved Hide resolved
catalyst_voices/packages/internal/catalyst_voices_services/lib/src/crypto/key_derivation.dart Outdated Show resolved Hide resolved
@dtscalac @stevenj
chore: extract account constant
063e107 
Co-authored-by: Steven Johnson <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx

@stevenj stevenj Awaiting requested review from stevenj

@damian-molinski damian-molinski Awaiting requested review from damian-molinski

Requested changes must be addressed to merge this pull request.

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Status: 🔖 Ready
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.
3 participants
@dtscalac @stevenj @damian-molinski