Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Upload seedphrase #1019

Merged
merged 11 commits into from
Oct 21, 2024
Merged

feat(cat-voices): Upload seedphrase #1019

merged 11 commits into from
Oct 21, 2024

Conversation

digitalheartxs
Copy link
Contributor

Description

Implementing Upload seedphrase

Related Issue(s)

Closes #946

Screenshots

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@digitalheartxs digitalheartxs added the draft Draft label Oct 17, 2024
@digitalheartxs digitalheartxs self-assigned this Oct 17, 2024
@damian-molinski damian-molinski marked this pull request as draft October 17, 2024 09:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 297/297}$ | ${\color{red}Fail: 0/297}$ |

@digitalheartxs digitalheartxs added review me PR is ready for review dart Pull requests that update Dart code and removed draft Draft labels Oct 17, 2024
@damian-molinski damian-molinski marked this pull request as ready for review October 17, 2024 12:42
dtscalac
dtscalac approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damian-molinski
damian-molinski approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit 95e7024 into main Oct 21, 2024
35 of 37 checks passed
@dtscalac dtscalac deleted the upload_seedphrase_946 branch October 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@damian-molinski damian-molinski damian-molinski approved these changes

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@digitalheartxs digitalheartxs

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK]: Upload SeedPhrase
3 participants
@digitalheartxs @damian-molinski @dtscalac