Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow username/password to be provided in configuration #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WattyRev
Copy link

@WattyRev WattyRev commented Jul 4, 2018

It seems like a nice option to be able to pass in a username/password instead of putting it in a .ftppass file. With this change, you could do something like:

grunt ftpush --my-username=watty --my-password=hunter2

With a configuration of

ftpush: {
            build: {
                auth: {
                    host: "myhost",
                    port: 21,
                    username: grunt.option("my-username"),
                    password: grunt.option("my-password")
                },
                ...
            }
        }

This change does not impact the previous key process, but will override that process if both username and password are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant