Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sloppy bob sh #77

Merged
merged 7 commits into from
Nov 24, 2024
Merged

Sloppy bob sh #77

merged 7 commits into from
Nov 24, 2024

Conversation

obiwac
Copy link
Member

@obiwac obiwac commented Nov 24, 2024 •
edited
Loading

Somehow, I was extremely sloppy when adding bob sh in #74

This fixes the following issues:

  • Forgot to add to README.
  • Ignores the first argument passed for some reason.
  • Explicit message when entering shell, so we don't get confused about if the command succeeded or not.
  • Tests! Merge Comprehensive test suite #76 for this first though ofc.

@obiwac obiwac added the bug Something isn't working label Nov 24, 2024
@obiwac obiwac mentioned this pull request Nov 24, 2024
Merged
19 tasks
@obiwac obiwac marked this pull request as ready for review November 24, 2024 19:19
@obiwac obiwac merged commit 712ea77 into main Nov 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obiwac