Fix frugality on FreeBSD #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, non-NUL-terminated strings were being passed to `str_hash`, which is obviously not right.
19 tasks
`step->unique` was never being set.
obiwac
added a commit
that referenced
this pull request
Nov 24, 2024
obiwac
added a commit
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, at least when building GrapeVine, frugality is not respected on FreeBSD.
Looking through the build output directory, it looks as though the cookies for files are changing on every build, which obviously should not happen.
That this is not happening on macOS is indicative of an uninitialized memory access issue, probably.
This could've been the opportunity to make Bob a fully self-tracking build system, but I think it makes more sense to wait for #61 before jumping into this.
We really need more tests for this!!! #67 again.
This PR also fixes build step merging. This is a bit of a separate issue, but it was small enough to be included along with this one.