Replace two almost identical classes with user_exception_selector
#2
+231
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbonczek
requested changes
Oct 24, 2024
- Use a custom constructor for convenience and type safety - Require `skipauth` argument in the constructor to differentiate - Generalize `find_users` algorithm - Remove unneeded `file` key from `get_options` return array (since it is not necessary to `require` the source file explicitly) - Add `set_exceptions_for_selected_users` convenience method - Drastically simplify `manage.php` as a result
daniil-berg
force-pushed
the
simplify-user-exception-class
branch
from
20bccca to
f416ced
Compare
larsbonczek
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipauthargument in the constructor to differentiatefind_usersalgorithmfilekey fromget_optionsreturn array (since it is not necessary torequirethe source file explicitly)set_exceptions_for_selected_usersconvenience methodmanage.phpas a result