Clean up code and fix linter warnings #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add return/parameter/property types wherever possible - Use imports/aliases instead of qualifiers wherever possible - Use shorthand array literal notation - Use array destructuring instead of `list` assignments - Remove redundant PHPdocs in a few inherited methods - Improve readability in a few instances * Use more consistent indentation * Use named arguments in function calls with many arguments * Use string interpolation instead of concatenation if possible - Define custom `user_2fa_loggedin::create_and_trigger` method - Add some TODOs
daniil-berg
force-pushed
the
lint-cleanup
branch
3 times, most recently
from
4f8a228 to
e9ea198
Compare
- Add `templates/manage_form.mustache` - Remove redundant `label` tags because they appear inside the selector element already via the option groups (analogous to the forum subscriber selectors) - Render template with selector HTML and other context from `manage.php`
daniil-berg
force-pushed
the
lint-cleanup
branch
from
e9ea198 to
dcfbcfb
Compare
larsbonczek
reviewed
Sep 20, 2024
Add back "redundant" return value descriptions in docblocks Improve readability slightly
daniil-berg
force-pushed
the
lint-cleanup
branch
from
17b404e to
0953ee0
Compare
larsbonczek
reviewed
Oct 14, 2024
larsbonczek
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listassignmentsuser_2fa_loggedin::create_and_triggermethod