Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ESP32 without the need of frozen modules #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rafaelaroca
Copy link

Some sentences were removed from the the library.

Copy link
Owner

@inmcm inmcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit mistakenly replaces the whole README for the main project. The content here is more appropriate for a README in the reduced version directory. In addition:

  • This should also be labeled clearly as a "reduced" feature version. The reduced version README should include rational as to what differs between the the full parser and the reduced version in order to make it fit on certain targets. You can point out this version will run without being on frozen on certain platform (esp32 in your application), but it general this is a smaller codebase for resource constrained devices.
  • The primary project README should include a section describing this reduced version of the parser for new visitors to the project

@inmcm
Copy link
Owner

inmcm commented Feb 19, 2022

Thank you for your pull request, but it needs some additional work.

  • Please label this as a "reduced" feature version and make the distinction clear there is a feature tradeoff to allow this version to run "un-frozen"
  • Fixes to the README docs as posted above
  • Please replicate the test suite for the reduced feature version and plumb it into the GitHub Actions CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants