Add pandas and numpy >= 2 compatibility #287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkopec87
commented
Dec 6, 2024
•
mkopec87
commented
- align requirements.txt with pyproject.toml
- remove calls to np.string_ not existing in numpy >= 2.0.0
- remove calls to pd._testing.makeMixedDataFrame not existing in new pandas versions
- fix install and test commands in documentation for developers
- replace np.mean with column-wise version
- drop pandas dependency constraint <2
- require Python 3.9 in pyproject.toml
- add PySpark 3.5.3 to test pipeline matrix
- update test pipeline matrix: exclude Python 3.8, include Python 3.12
mkopec87
force-pushed
the
feature/update-pandas
branch
2 times, most recently
from
c32e4ad to
b5f7f11
Compare
|
Still 5 failing tests :( BTW. do we need 'requirements.txt' for anything? |
mkopec87
force-pushed
the
feature/update-pandas
branch
3 times, most recently
from
ecd46d1 to
6e0e1e6
Compare
- align requirements.txt with pyproject.toml - remove calls to np.string_ not existing in numpy >= 2.0.0 - remove calls to pd._testing.makeMixedDataFrame not existing in new pandas versions - fix install and test commands in documentation for developers - replace np.mean with column-wise version - drop pandas dependency constraint <2 - require Python 3.9 in pyproject.toml - add PySpark 3.5.3 to test pipeline matrix - update test pipeline matrix: exclude Python 3.8, include Python 3.12 - add test notebook output to .gitignore - switch to importlib from pkg_resources - install project dependencies after pyspark in spark build tests
mkopec87
force-pushed
the
feature/update-pandas
branch
from
6e0e1e6 to
cfc85d1
Compare
sbrugman
reviewed
Dec 20, 2024
| @@ -233,7 +238,7 @@ def __init__( | |||
| :param kwargs: (dict, optional): residual kwargs passed on to mean and std functions | |||
| """ | |||
| super().__init__( | |||
| np.mean, | |||
| ReferencePullCalculator.mean, | |||
There was a problem hiding this comment.
functools.partial could be used here instead of staticmethod
sbrugman
reviewed
Dec 20, 2024
| @@ -13,6 +13,11 @@ | |||
| from popmon.base import Pipeline | |||
|
|
|||
|
|
|||
| def mean(x): | |||
| """ "Column-wise mean version,""" | |||
| return np.mean(x, axis=0) | |||
There was a problem hiding this comment.
from functools import partial
partial(np.mean, axis=0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.