Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/user input changed listbox #1971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gerjanvangeest
Copy link
Member

What I did

fix: #1964

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: ed9748f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerjanvangeest gerjanvangeest force-pushed the fix/user-input-changed-listbox branch 2 times, most recently from f8e0091 to fc56a51 Compare April 26, 2023 08:42
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023

CLA assistant check
All committers have signed the CLA.

@tlouisse
Copy link
Member

tlouisse commented May 1, 2023

Also see #1964 (comment)
If we use user-input-changed as a public event, we would need to adjust our comments and docs as well, but we probably need to internally discuss a consistent future plan first.

The less apis that do the same thing, the better. But as always, we should really work on docs and api tables now.

@gerjanvangeest gerjanvangeest force-pushed the fix/user-input-changed-listbox branch from fc56a51 to ed9748f Compare May 3, 2023 09:12
@gerjanvangeest gerjanvangeest added the discussion Discussing technologies or larger scale decisions label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussing technologies or larger scale decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LionSelectRich] form event not dispatched
3 participants