Refactor the autoscaling tests into a telemtry_autoscaling role in fvt #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for other refactors. This will allow for setting some default values for vars, so that the existing playbooks still run as they did previously without need to update the scripts running them. having the role will also allow to use the file/ and templates/ sub-directories, and add some additional configurability to the role.
* remove trailing whitespace * use fqcn for modules * resolve "no-free-form" * name[casing]: All names should start with an uppercase letter. * name[missing]: All tasks should be named. * yaml[empty-lines]: Too many blank lines (1 > 0)
To remove previous entries for the IP address, since the VMs will reuse the IP addresses, and this will cause the ssh commands to fail, due to looking like a main-in-the-middle attack.
When updating the python-observabilityclient, the flag was omitted, and package wasn't re-installed. The alarm query needed to be reverted, since it was revised when debugging.
The telemetry_autoscaling role has been moved to http://github.com/infrawatch/feature-verification-tests
|
I just added the var fvt_dir static directly , as we are using it as temporary solution we don't need to set it in set_fact, it was causing error. to confirm we keeping the other playbooks to be used in osp17 right ? as for osp18 we only use autoscaling_osp18.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.