OH2-433 | Implement token refresh #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverD3
suggested changes
Nov 18, 2024
There was a problem hiding this comment.
Use setInterval to check every 5 seconds if the token has expired and refresh isn't the most efficient way to achieve token refresh. I would opt for checking the token expiration when a request is sent (if we received a 401, for example) and try to refresh the token.
With the current implementation, token and token refresh will never expired as long as the OH tab in the browser is open, even the user does nothing.
|
Hi guys, ready to be merged? How can I test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-433