Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1043 | Implement user / user group soft deletion #692

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Nov 7, 2024

See OP-1043
Paired with #496

@mwithi
Copy link
Member

mwithi commented Nov 11, 2024

When I try to delete and already soft-deleted user the error message is empty (fixed)

@mwithi
Copy link
Member

mwithi commented Nov 11, 2024

If I deleted a group with users in it, it shows an empty error message, but the group is correctly set as deleted (fixed)

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi
Copy link
Member

mwithi commented Nov 11, 2024

Sorry... like in GUI, when editing an already deleted group, changing only the description, it blocks the operation (we can live with it IMHO) but the error message is not translated (fixed).

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 1e9f092 into informatici:develop Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants