Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-400 | OH2-403 Refactoring ResponseEntity #686

Merged

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Oct 31, 2024

See OH2-400 and OH2-403.

Alignement of changes brought by #482

@mwithi mwithi changed the title chore:align with spec file OH2-400 | OH2-403 Refactoring ResponseEntity Oct 31, 2024
Copy link
Contributor

@SteveGT96 SteveGT96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mwithi
mwithi previously approved these changes Nov 6, 2024
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by @SteveGT96

@mwithi mwithi dismissed their stale review November 6, 2024 14:05

Found new issues

@mwithi
Copy link
Member

mwithi commented Nov 6, 2024

Don't know if it is related to API or UI.

image

@SilverD3
Copy link
Contributor Author

SilverD3 commented Nov 7, 2024

Don't know if it is related to API or UI

informatici/openhospital-api#498 (comment)

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit d57cf64 into informatici:develop Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants