Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-401 | Fix admission state slice #669

Merged

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Oct 3, 2024

See OH2-401

Needs #670 to be merged

@mwithi mwithi requested a review from SteveGT96 October 3, 2024 14:23
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test (real DB) fails:

image

Retry response:

{
    "type": "about:blank",
    "title": "Not Found",
    "status": 404,
    "detail": "No static resource users/admin/settings/dashboard.",
    "instance": "/users/admin/settings/dashboard"
}

Reset (no response):
image

Refresh (same as before):
image

@SilverD3
Copy link
Contributor Author

SilverD3 commented Oct 4, 2024

I see, as #465 has been merged, we need to align API specs in the FE.
I open an issue to align the FE

@SilverD3
Copy link
Contributor Author

SilverD3 commented Oct 7, 2024

@mwithi please test again

@mwithi
Copy link
Member

mwithi commented Oct 7, 2024

@mwithi please test again

ok, now it's working, thanks!

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit a132f71 into informatici:develop Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants