Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update oh.yaml from api+ generated #662

Merged
merged 4 commits into from
Sep 20, 2024
Merged

chore: update oh.yaml from api+ generated #662

merged 4 commits into from
Sep 20, 2024

Conversation

gasp
Copy link
Contributor

@gasp gasp commented Sep 12, 2024 •
edited
Loading

  • copy oh.yaml from openhospital-api to openhospital-ui
  • generate new api files with npm run build:api
  • fix conflicts
  • test with real api

@gasp gasp marked this pull request as draft September 12, 2024 14:16
@gasp gasp marked this pull request as ready for review September 13, 2024 09:07
@gasp gasp requested a review from mwithi September 13, 2024 09:07
mwithi
mwithi reviewed Sep 13, 2024
View reviewed changes
src/generated/runtime.ts Outdated Show resolved Hide resolved
@mwithi mwithi requested a review from SilverD3 September 13, 2024 09:17
@gasp gasp force-pushed the chore-update-oh-yaml branch from 7689839 to 55c8f7b Compare September 13, 2024 11:02
SilverD3
SilverD3 suggested changes Sep 19, 2024
View reviewed changes
src/generated/runtime.ts Outdated Show resolved Hide resolved
src/generated/runtime.ts Show resolved Hide resolved
@SilverD3 SilverD3 mentioned this pull request Sep 19, 2024
Merged
5 tasks
@gasp gasp force-pushed the chore-update-oh-yaml branch from 872de74 to bdf46a4 Compare September 19, 2024 15:25
@gasp gasp requested a review from SilverD3 September 19, 2024 15:26
SilverD3
SilverD3 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge

@SilverD3
Copy link
Contributor

@gasp please resolve unresolved conversations

mwithi
mwithi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by @SilverD3

@mwithi mwithi merged commit 60fbbff into informatici:develop Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilverD3 SilverD3 SilverD3 approved these changes

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasp @SilverD3 @mwithi