Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OH2-244 | Customize Landing page #536

Merged
merged 4 commits into from
Dec 6, 2023
Merged

OH2-244 | Customize Landing page #536

merged 4 commits into from
Dec 6, 2023

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Dec 4, 2023 •
edited by mwithi
Loading

See OH2-244.

@mwithi mwithi changed the title OH2-244 | [state.main.settings.status, state.main.authentication.status] OH2-244 | Customize Landing page Dec 4, 2023
mwithi
mwithi reviewed Dec 4, 2023
View reviewed changes
src/generated/runtime.ts Outdated Show resolved Hide resolved
mwithi
mwithi previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi dismissed their stale review December 6, 2023 09:21

Still ongoing changes

mwithi
mwithi approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Anyway, there are some pitfalls to be tackled in another issue.

@mwithi mwithi merged commit 0aa4415 into informatici:develop Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveGT96 @mwithi