Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OH2-193 | Display dashboard components base on user role/permission #535

Merged
merged 7 commits into from
Dec 6, 2023
Merged

OH2-193 | Display dashboard components base on user role/permission #535

merged 7 commits into from
Dec 6, 2023

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Dec 1, 2023 •
edited
Loading

See OH2-193.

Changes

  • Align APIs and Models with spec file.
  • Update TPermission type
  • Use Authenticated user permission to display dashboard widgets

@SilverD3
Copy link
Contributor Author

SilverD3 commented Dec 1, 2023

The API PUT /users/settings/{1} used to update UserSetting is not working. That's why I marked this PR as draft.

@mwithi
Copy link
Member

mwithi commented Dec 1, 2023

The API PUT /users/settings/{1} used to update UserSetting is not working. That's why I marked this PR as draft.

Could please report the error you get?

@SilverD3
Copy link
Contributor Author

SilverD3 commented Dec 1, 2023

Something like "A setting with the same name already exists"

@mwithi
Copy link
Member

mwithi commented Dec 1, 2023

Something like "A setting with the same name already exists"

pushed fix on api, please check, thanks

@SilverD3 SilverD3 marked this pull request as ready for review December 1, 2023 16:48
@SilverD3
Copy link
Contributor Author

SilverD3 commented Dec 1, 2023

Looks good.

I've test with the four users in the demo database.

@SilverD3 SilverD3 changed the title OH2-149 | Display dashboard components base on user role/permission OH2-193 | Display dashboard components base on user role/permission Dec 4, 2023
mwithi
mwithi approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit b2d86f5 into informatici:develop Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilverD3 @mwithi