Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHCS-73 OHCS-100 OH2-232 OH2-233 OHCS-107 | Remove material field all over the app and fix patient without picture #519

Merged

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Sep 19, 2023

@mwithi
Copy link
Member

mwithi commented Sep 19, 2023

Please can you remove it also from collapsable sections in other parts of the application?

@SilverD3
Copy link
Contributor Author

Please can you remove it also from collapsable sections in other parts of the application?

Done !

@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

I can still see it in Clinic, the Exam note field instead is disappeared

image

@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

Also, the field should be removed from CSS for Print (wrapping long fields already requested with OH2-233)

image

@SilverD3
Copy link
Contributor Author

SilverD3 commented Sep 21, 2023

"note" field only appears if it's not null or not empty.
Issues concerning printing should be solved in another task, i think.

@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

"note" field only appears if it's not null or not empty. Issues concerning printing should be solved in another task, i think.

The note field is not empty as showed in the second screenshot. When you commit "Remove material in the entire app" one expects so, not in another task.

@SilverD3
Copy link
Contributor Author

Please, notice fixed issues mentioned in the PR description.

Is there still an issue with note field ?

@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

Please, notice fixed issues mentioned in the PR description.

Is there still an issue with note field ?

Picture solved. Material in CSS solved.

The note field is still not visible in Clinic (while does in CSS print):

image

image

@mwithi mwithi changed the title OHCS-73 | Remove material field form lab form OHCS-73 OHCS-100 OH2-232 | Remove material field all over the app and fix patient without picture Sep 21, 2023
@SilverD3
Copy link
Contributor Author

SilverD3 commented Sep 21, 2023

The note is displayed (see the screenshot)
Screenshot 2023-09-21 at 11-49-51 Open Hospital

I've fixed issue OHCS-107.
To reproduce this issue, you have to intentionally return error in the backend (as it may be difficult to simulate in the frontend) when updating the patient. Then in the frontend, try to update a patient (you'll get error) and then go to the visits section in the patient activities dashboard. You will see the error displayed, just after patient extra data.

@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

The note is displayed (see the screenshot)

There is something wrong here, because also the one of Admisison disappears when I expand the Exam section:

image

image

@mwithi mwithi changed the title OHCS-73 OHCS-100 OH2-232 | Remove material field all over the app and fix patient without picture OHCS-73 OHCS-100 OH2-232 OHCS-107 | Remove material field all over the app and fix patient without picture Sep 21, 2023
@mwithi
Copy link
Member

mwithi commented Sep 21, 2023

now it works!

image

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 9a7a575 into informatici:develop Sep 21, 2023
3 checks passed
@mwithi mwithi changed the title OHCS-73 OHCS-100 OH2-232 OHCS-107 | Remove material field all over the app and fix patient without picture OHCS-73 OHCS-100 OH2-232 OH2-233 OHCS-107 | Remove material field all over the app and fix patient without picture Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants