Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-218 Show remaining characters on text fields #514

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Sep 15, 2023

See OH2-218.

I've identified following forms :

  • Patient form (/patients/new)
  • Patient search form (/patients/search)
  • Admission form (/patients/details/{id}/admissions)
  • Visit form (/patients/details/{id}/visits)
  • Triage form (/patients/details/{id}/triage)
  • Operation form (/patients/details/{id}/operation)
  • Discharge form (/patients/details/{id}/discharge)
  • Lab form (/laboratory/new)

I've modified the custom TextField component (src/components/accessories/textField/TextField.tsx). To use the feature, just specify the prop maxLength on that component.

@mwithi mwithi changed the title Show remaining characters on text fields OH2-218 Show remaining characters on text fields Sep 15, 2023
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit dc2ca46 into informatici:develop Sep 15, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants