OH2-418 | Orthanc Integration #1466
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way for ORTHANC resources consuming
OH2-419 - Add endpoints to map ORTHANC APIs | OH2-420 - Add Gateway for ORTHANC resources consuming
…-core into integrations/orthanc
…openhospital-core into integrations/orthanc
chore:migration scripts for radiology permissions
chore:refactor date parser methods
dbmalkovsky
reviewed
Dec 10, 2024
| */ | ||
| public LocalDate creationDateToLocalDate() { | ||
| if (creationDate == null || creationDate.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
dbmalkovsky
reviewed
Dec 10, 2024
| */ | ||
| public LocalTime creationTimeToLocalTime() { | ||
| if (creationTime == null || creationTime.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
dbmalkovsky
reviewed
Dec 10, 2024
| */ | ||
| public LocalDate birthDateToLocalDate() { | ||
| if (birthDate == null || birthDate.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
dbmalkovsky
reviewed
Dec 10, 2024
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
Project standards use braces even for single statement bodies.
dbmalkovsky
reviewed
Dec 10, 2024
| */ | ||
| public LocalTime timeToLocalTime() { | ||
| if (time == null || time.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
dbmalkovsky
reviewed
Dec 10, 2024
| */ | ||
| public LocalDate dateToLocalDate() { | ||
| if (date == null || date.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
dbmalkovsky
reviewed
Dec 10, 2024
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
again, please use braces
dbmalkovsky
reviewed
Dec 10, 2024
| public boolean testConnection() throws OHServiceException, OHRestClientException { | ||
| String time = feignClientFactory.createClient(true).testConnection(); | ||
|
|
||
| return time != null && !time.isEmpty() ; |
There was a problem hiding this comment.
Suggested change
| return time != null && !time.isEmpty() ; | |
| return time != null && !time.isEmpty(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-418