Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1197 | Validate ward Inventory #1456

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

OP-1197 | Validate ward Inventory #1456

wants to merge 24 commits into from
+364 −6

Conversation

JantBogard
Copy link
Contributor

@JantBogard JantBogard commented Nov 20, 2024 •
edited by jira bot
Loading

See OP-1197

dbmalkovsky
dbmalkovsky requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments inline.

@mwithi mwithi mentioned this pull request Nov 21, 2024
Open
@dbmalkovsky
Copy link
Collaborator

@JantBogard please resolve the conflicts; thanks

@JantBogard JantBogard requested a review from mwithi December 12, 2024 13:23
mwithi
mwithi reviewed Dec 17, 2024
View reviewed changes
src/main/java/org/isf/medicalinventory/manager/MedicalInventoryManager.java
* @return {@link MedicalInventory}. It could be {@code null}.
* @throws OHServiceException
*/
public MedicalInventory actualizeMedicalWardInventoryRow(MedicalInventory inventory) throws OHServiceException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this method is still missing tests.
@ArnaudFofou, did you check the tests for the OP-1199 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi left review comments

@dbmalkovsky dbmalkovsky Awaiting requested review from dbmalkovsky

@ArnaudFofou ArnaudFofou Awaiting requested review from ArnaudFofou

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JantBogard @dbmalkovsky @mwithi @ArnaudFofou