Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.syslog): Fix for tests that started failing in 2025 #16364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zak-pawel
Copy link
Collaborator

Summary

The RFC 3164 standard does not provide a year for the TIMESTAMP field (https://datatracker.ietf.org/doc/html/rfc3164#section-4.1.2), which is why the plugin, when parsing the timestamp, sets the current year.

For both RFC 3164 tests, the timestamp is Dec 2 16:31:03.
In 2024, it parsed to 1733157063000000000.
In 2025, it parsed to 1764693063000000000.

In this PR, I'm updating the expected timeout to 2025. This is just a workaround that will stop working in 2026.

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added area/syslog fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 2, 2025
@zak-pawel zak-pawel requested review from srebhan and DStrand1 January 2, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/syslog fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants