Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.kinesis_consumer): Store iterator of last delivered message, not first #16304

Closed
wants to merge 1 commit into from

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 13, 2024

Summary

When storing shard iterators in DynamoDB the current code stores the iterator of the first metric delivered in the current interval to the outputs. This is sub-optimal if many messages delivered in a bulk and telegraf is exited before the next gather cycle.

This PR fixes the issue by storing the iterator of the last metric delivered.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 13, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan
Copy link
Member Author

srebhan commented Dec 16, 2024

Closing this PR as it makes things worse not better. :-)

@srebhan srebhan closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant