Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter findings for revive:unused-receiver in plugins/inputs/[a-e] #16263

Merged

Conversation

zak-pawel
Copy link
Collaborator

Summary

Address findings for revive:unused-receiver in plugins/inputs/[a-e]*.

It is only part of the bigger work for #16190.
After all findings of this type in whole project are handled, we can enable revive:unused-receiver rule in golangci-lint.

Checklist

  • No AI generated code was used in this PR

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Looks good, only a few suggestions to get rid of some more underscores.

plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cloud_pubsub/cloud_pubsub.go Outdated Show resolved Hide resolved
plugins/inputs/cloud_pubsub_push/cloud_pubsub_push.go Outdated Show resolved Hide resolved
plugins/inputs/cloudwatch/cloudwatch_test.go Outdated Show resolved Hide resolved
plugins/inputs/cloudwatch/cloudwatch_test.go Outdated Show resolved Hide resolved
plugins/inputs/dcos/creds.go Outdated Show resolved Hide resolved
plugins/inputs/elasticsearch/elasticsearch.go Outdated Show resolved Hide resolved
plugins/inputs/elasticsearch_query/elasticsearch_query.go Outdated Show resolved Hide resolved
plugins/inputs/execd/shim/shim_test.go Outdated Show resolved Hide resolved
plugins/inputs/execd/shim/shim_test.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 13, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Dec 13, 2024
@DStrand1 DStrand1 merged commit 516b8cf into influxdata:master Dec 13, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.33.1 milestone Dec 13, 2024
justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Dec 19, 2024
izekr pushed a commit to izekr/telegraf that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants