test(models): Cleanup tests, unexport stuff and unify naming in tests #16116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
force-pushed
the
model_test_cleanup
branch
from
dbed43e to
edf5408
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
DStrand1
reviewed
Nov 4, 2024
| path := t.TempDir() | ||
| walfile, err := wal.Open(filepath.Join(path, "123"), nil) | ||
| require.NoError(t, err) | ||
| defer walfile.Close() |
There was a problem hiding this comment.
This defer should be unneeded since its explicitly called later right?
There was a problem hiding this comment.
No I don't think it is unnecessary because the test can fail in between (with the require calls) and the file would be left open. So the double close should be fine to not leak anything...
DStrand1
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans the
modelstests a bit in preparation of submitting the partial-write-error implementation. No functional changes...Checklist
Related issues