-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs.prometheus_client): Always default to TCP #14471
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix @powersj! Thanks!
(cherry picked from commit 9ec0894)
Summary
#14108 introduced the ability to listen on vsock. In that PR, telegraf parses the URL and determines which function to call based on the scheme of the URL. This function was missing what to do when there is no scheme, breaking backwards compatibility. Additionally, if using a URL like
mgt:3839
, scheme will report asmgt
. To maintain backwards compatibility we should always try TCP.Checklist
Related issues
resolves #14468