test(inputs.vault): Avoid hard-compare of metrics #14221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the integration test we spin up a real vault instance in a docker container and hit the metrics endpoint. However, the number of metrics reported by this endpoint change depending on how long the instance has been up. For example, the longer then container is up additional metrics about the go runtime start to show up. This means doing a hard-comparison of the metrics we expect is not a good idea and instead we should ensure that we collected without error. We already have unit tests that validate we can correctly parse the various types of metrics.
telegraf-tiger
bot
added
plugin/input
powersj
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
|
Closing in favor of #14222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the integration test we spin up a real vault instance in a docker container and hit the metrics endpoint. However, the number of metrics reported by this endpoint change depending on how long the instance has been up.
For example, the longer then container is up additional metrics about the go runtime start to show up.
This means doing a hard-comparison of the metrics we expect is not a good idea and instead we should ensure that we collected without error. We already have unit tests that validate we can correctly parse the various types of metrics.