Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(openstack): put quote around interval value #14174

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

MindTooth
Copy link
Contributor

Being a novice, I struggled with TOML errors. Found it to be missing quotes.

Required for all PRs

$ make lint
golangci-lint run
ERRO Running error: unknown linters: 'gocheckcompilerdirectives', run 'golangci-lint help linters' to see the list of supported linters 
make: *** [lint] Error 3
$ make check-deps
+github.com/99designs/go-keychain


The docs/LICENSE_OF_DEPENDENCIES.md file does not contain the expected entries.

Lines prefixed with '+' should be added to LICENSE_OF_DEPENDENCIES.md and '-'
lines should be removed.

Include a link to the appropriate licenses for any additions.
make: *** [check-deps] Error 1
$ make test  # ✅ 
$ make docs  # ✅ 

resolves #

Being a novice, I struggled with TOML errors. Found it to be missing
quotes.
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the docs Issues related to Telegraf documentation and configuration descriptions label Oct 24, 2023
@MindTooth
Copy link
Contributor Author

!signed-cla

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@powersj powersj merged commit 04480a5 into influxdata:master Oct 24, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.28.4 milestone Oct 24, 2023
powersj pushed a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to Telegraf documentation and configuration descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants