chore(tools): Cache rework for .circleci jobs (part2)
#14156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak-pawel
changed the title
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
zak-pawel
changed the title
.circleci jobs (part2)
powersj
reviewed
Oct 23, 2023
| } | ||
|
|
||
| export PATH="/c/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin:$PATH" | ||
| echo "$PATH" |
There was a problem hiding this comment.
This is printed here and below, are both necessary?
There was a problem hiding this comment.
@powersj Just to see what chocolatey added to the $PATH
srebhan
approved these changes
Oct 24, 2023
srebhan
added
the
ready for final review
powersj
approved these changes
Oct 24, 2023
powersj
pushed a commit
that referenced
this pull request
Nov 13, 2023
(cherry picked from commit 4413991)
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Dec 15, 2023
This reverts commit 4413991.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement/fixes
windows:go, so we need to be sure that duringgoupgrade there will not be any clashes or leftovers (like we could observe here) so/c/Program Files/Gowill be removed just beforerestore_cache. These clashes may also appear duringgoupgrade from previously cached version to newer version.MinGWwill also be cached and/c/ProgramData/chocolatey/lib/mingwwill be removed just beforerestore_cache(for the same reason as forgomentioned above).$PATHmanipulations were also needed (to check for originalgccinside/c/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/binand not for shim version in/c/ProgramData/chocolatey/bin) when installingMinGWand running tests with-race.darwin:/usr/local/Cellar/goand create it with proper ownership just beforerestore_cache. It was done to fix a lot ofpermission deniederrors which occurred during cache restore. Introduced during update frommacos.x86.medium.gen2tomacos.m1.medium.gen1.go-bins-<< parameters.cache_version >>-<< parameters.os >>-<< parameters.arch >>-go<< parameters.goversion >>-{{ checksum "go.sum" }}go-caches-<< parameters.cache_version >>-<< parameters.os >>-<< parameters.arch >>-go<< parameters.goversion >>-{{ checksum "go.sum" }}$PATH, binary (go/gcc) location and version added.