Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): Bump golangci-lint from v1.54.2 to v1.55.0 #14155

Merged
merged 4 commits into from
Oct 23, 2023
Merged

chore(tools): Bump golangci-lint from v1.54.2 to v1.55.0 #14155

merged 4 commits into from
Oct 23, 2023

Conversation

zak-pawel
Copy link
Collaborator

This PR bumps golangci-lint from v1.54.2 to v1.55.0 and fixes the newly found issues:

plugins/inputs/aerospike/aerospike.go:441:9             revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/chrony/chrony_test.go:99:2               revive      early-return: if c { ... } else { ... os.Exit() } can be simplified to if !c { ... os.Exit() } ...
plugins/inputs/csgo/csgo.go:180:9                       revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/dcos/dcos.go:352:9                       revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/disk/disk.go:100:9                       revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/ipmi_sensor/ipmi_sensor_test.go:378:2    revive      early-return: if c { ... } else { ... os.Exit() } can be simplified to if !c { ... os.Exit() } ...
plugins/inputs/ipmi_sensor/ipmi_sensor_test.go:576:2    revive      early-return: if c { ... } else { ... os.Exit() } can be simplified to if !c { ... os.Exit() } ...
plugins/inputs/kube_inventory/kube_inventory.go:198:64  nolintlint  directive `//nolint:gosec // G101: Potential hardcoded credentials - false positive` is unused for linter "gosec"
plugins/inputs/kube_inventory/kube_inventory.go:201:64  nolintlint  directive `//nolint:gosec // G101: Potential hardcoded credentials - false positive` is unused for linter "gosec"
plugins/inputs/monit/monit.go:341:9                     revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/procstat/procstat.go:354:9               revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/sensors/sensors_test.go:373:2            revive      early-return: if c { ... } else { ... os.Exit() } can be simplified to if !c { ... os.Exit() } ...
plugins/inputs/snmp/snmp.go:428:12                      revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/statsd/running_stats.go:110:9            revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/outputs/opentsdb/opentsdb.go:100:9              revive      indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/parsers/influx/escape.go:83:9                   gosec       G103: Use of unsafe calls should be audited

@telegraf-tiger telegraf-tiger bot added the chore label Oct 20, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the new findings @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 23, 2023
@powersj
Copy link
Contributor

powersj commented Oct 23, 2023

Thank you!

@powersj powersj merged commit 171dccb into influxdata:master Oct 23, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.28.3 milestone Oct 23, 2023
powersj pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants